Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (kustomize): missing permissions for grafanacontactpoint in rbac.yaml for kustomize #1539

Merged
merged 3 commits into from
May 17, 2024

Conversation

talron23
Copy link
Contributor

5.9.0 introduced grafanacontactpoint #(1474), and the needed rbac permissions were added to config/rbac/role.yaml, but not to the kustomize deployment

…yaml

5.9.0 introduced grafanacontactpoint (grafana#1474), and the needed rbac permissions were added to config/rbac/role.yaml, but not to the kustomize deployment
@CLAassistant
Copy link

CLAassistant commented May 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@NissesSenap NissesSenap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the first time we have missed this. We should probably write a script to verify that this stops happening :).
Thanks for this

@NissesSenap NissesSenap merged commit 5f32bb6 into grafana:master May 17, 2024
10 checks passed
@weisdd
Copy link
Collaborator

weisdd commented May 20, 2024

@talron23 FYI: we've updated our Makefile to keep RBAC in sync across deployment methods (#1540).

@talron23 talron23 deleted the fix/kustomize-permissions branch May 27, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants