-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging options to Helm chart #1691
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Configuration for logging is certainly useful, and nice catch around missing options securityContext
in kustomize.
I certainly did not expect to leave so many comments on a simple PR, but since you've made many changes in various places (not necessarily related to the initial idea behind the PR), there are more things to point at.
@weisdd Thanks for the thorough review! I've applied your suggestions. patches:
- target:
apiVersion: apps/v1
kind: Deployment
name: grafana-operator-controller-manager
patches: |-
- op: add
path: /spec/template/spec/containers/0/args/-
value: -zap-encoder=json |
@Baarsgaard In my view, the way you did it (commented-out section) is good enough for now. In future, it would be handy to just have a separate page in docs where we would list all available configuration options like logging flags or whatever else. It doesn't have to be ArgoCD-specific - in the end, people who use it know enough to patch resources themselves, they just need to know which arguments to pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During today's meeting, we (maintainers) discussed this PR.
- It was decided to remove references to zap logging flags from Kustomize (done). @theSuess will prepare documentation instead;
- I've noticed that the default setting for time did not match the previous format (
rfc3339
, which is made the default throughoperator-sdk
), that is fixed now.
For the rest, the PR should be good to merge. Thanks for your contribution!
Expose available logging options in the Helm chart.
Useful for people who use structured logging solutions.
I found #1659 and thought it would be a quick fix.
I also found some securityContext options that were not replicated to/from the kustomize configuration, those were aligned along with the logging args.
Replication steps: