Time regions support in graph panel

[marefr]

Fixes #5930

Example dashboard using Grafana Testdata datasource: https://gist.github.com/marefr/2fee183a7b566ab12c6477fccec5a887

[torkelo]

I wonder how much conflict this will have with the major refactorings in https://github.com/grafana/grafana/pull/12060/files

[marefr]

Good question :) Barely no changes to the "value" thresholds in this PR so no conflicts per se with that other PR. But if we want this to be in React as well, then yes there are a lot of changes needed

[torkelo]

Maybe thresholds are the wrong name for this? Been thinking about thresholds recently and how we can align the thresholds model & UI across panels. But this feels a lot different. more like Colored Time Regions or Time Markings.

[marefr]

Yes agree, but you mean thresholds in general? Colored Time Regions or Time Markings are exactly the same as Colored Value Regions or Value Markings, right?

[marefr]

@torkelo did some work on this:

• No longer combined with thresholds and moved to a separate section under Display tab
• The whole concept/feature is now called "time regions"

[perplexityjeff]

This is a great feature that we are looking for to be added to Grafana. Is there any update for this request at this moment?

[marefr]

@perplexityjeff hopefully it can be included in v5.4.

[StephenOTT]

Any plans to add this into other panel types such as HeatMap? thinking prometheus histogram heatmap usage as a example.

[marefr]

@StephenOTT not at the moment. That panel is using d3 so it's not that easy to implement just by copy this solution. Please open a separate issue for heatmap time regions.

[torkelo]

Looks really great. Sorry for taking for every to review & test this.

I would remove the background %3 & %6 and rename background %9 with Gray. And maybe add a blue transparent color as well.

[marefr]

Replaced background color modes with Gray. Added blue color. Moved custom to bottom.

[Gauravshah]

Are there plans to support timezone ? if there are some directions we would love to contribute

[marefr]

@Gauravshah what do you mean? You configure times that correlates to UTC. Changing timezone of dashboard to local browser time will adjust the time regions accordingly.

[Gauravshah]

@marefr lets say my timezone is PT ( Los Angeles ). I select Sat as my time region. It would show on my graph as Friday night 8 PM to Saturday 8 PM. Then lets say then I pick Sat 8 AM to Sun 8:AM which will correctly show as Saturday PT. But this would go off when we change DST. We would need to go back and fix all dashboards from 8 AM to 7 AM

[marefr]

I would say then use UTC time in dashboard as timezone instead or open a feature request issue.

[Gauravshah]

@marefr I think there are valid uses cases around using time zone. Will open a feature request.