Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility do add common labels in helm chart #3319

Closed
Rohlik opened this issue Sep 18, 2024 · 2 comments · Fixed by #3379, #3381, #3384 or #3385 · May be fixed by #3380
Closed

Add possibility do add common labels in helm chart #3319

Rohlik opened this issue Sep 18, 2024 · 2 comments · Fixed by #3379, #3381, #3384 or #3385 · May be fixed by #3380

Comments

@Rohlik
Copy link
Contributor

Rohlik commented Sep 18, 2024

Is your feature request related to a problem? Please describe.
There is no way how to easily set common labels across all Helm chart Tempo created resources, like (deployments, statefulsets, ingresses, services, servicemonitors, persistent volumes, etc). This leads to difficulties when you have common rules/alerts, for example, "almost full persistent volume" and you want to route them to the responsible owner based on the team label. This is now impossible as the PV/PVC doesn't have related labels 😢.

Describe the solution you'd like
In values.yaml, we should be able to specify something like this:

commonLabels:
  foo: bar
  label2: value2

and all resources created by the Tempo chart will have those labels.

Describe alternatives you've considered

Additional context
Sadly, the other components from Grafana are missing this support also 😣; see tickets below. It would be nice to have the same method for setting these common labels across charts.

@joe-elliott
Copy link
Member

I am fully in support of this. Moving this to the helm charts repo for visibility.

We would gladly take a PR to add this feature.

@joe-elliott joe-elliott transferred this issue from grafana/tempo Sep 19, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 26, 2024
@ftrigari
Copy link
Contributor

I edited 3 Tempo Charts using the same logic used for Mimir chart.

I didn't edit dependency charts; I'm waiting for a feedback on how to proceed grafana/mimir#9067 (comment)

ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 29, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Oct 30, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Nov 1, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Nov 1, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Nov 1, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Nov 1, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Nov 1, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Nov 1, 2024
ftrigari added a commit to ftrigari/helm-charts that referenced this issue Nov 1, 2024
zanhsieh added a commit that referenced this issue Nov 3, 2024
zanhsieh added a commit that referenced this issue Nov 3, 2024
[agent-operator] Add commonLabels (#3319)
Sheikh-Abubaker added a commit that referenced this issue Nov 5, 2024
[tempo-vulture] Add commonLabels (#3319)
Sheikh-Abubaker added a commit that referenced this issue Nov 5, 2024
[rollout-operator] Add commonLabels (#3319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment