-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility do add common labels in helm chart #3319
Closed
Comments
I am fully in support of this. Moving this to the helm charts repo for visibility. We would gladly take a PR to add this feature. |
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 26, 2024
Signed-off-by: fabio trigari <[email protected]>
I edited 3 Tempo Charts using the same logic used for Mimir chart. I didn't edit dependency charts; I'm waiting for a feedback on how to proceed grafana/mimir#9067 (comment) |
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 29, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 29, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 29, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 29, 2024
Signed-off-by: fabio trigari <[email protected]>
This was referenced Oct 29, 2024
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 29, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 29, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 29, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 29, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 29, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 29, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 29, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 29, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 29, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 29, 2024
Signed-off-by: fabio trigari <[email protected]>
This was referenced Oct 29, 2024
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 30, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 30, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 30, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 30, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 30, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 30, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 30, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 30, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 30, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Oct 30, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Nov 1, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Nov 1, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Nov 1, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Nov 1, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Nov 1, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Nov 1, 2024
Signed-off-by: fabio trigari <[email protected]>
ftrigari
added a commit
to ftrigari/helm-charts
that referenced
this issue
Nov 1, 2024
Signed-off-by: fabio trigari <[email protected]>
zanhsieh
added a commit
that referenced
this issue
Nov 3, 2024
[agent-operator] Add commonLabels (#3319)
Sheikh-Abubaker
added a commit
that referenced
this issue
Nov 5, 2024
[tempo-vulture] Add commonLabels (#3319)
Sheikh-Abubaker
added a commit
that referenced
this issue
Nov 5, 2024
[rollout-operator] Add commonLabels (#3319)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
There is no way how to easily set common labels across all Helm chart Tempo created resources, like (deployments, statefulsets, ingresses, services, servicemonitors, persistent volumes, etc). This leads to difficulties when you have common rules/alerts, for example, "almost full persistent volume" and you want to route them to the responsible owner based on the team label. This is now impossible as the PV/PVC doesn't have related labels 😢.
Describe the solution you'd like
In
values.yaml
, we should be able to specify something like this:and all resources created by the Tempo chart will have those labels.
Describe alternatives you've considered
Additional context
Sadly, the other components from Grafana are missing this support also 😣; see tickets below. It would be nice to have the same method for setting these common labels across charts.
The text was updated successfully, but these errors were encountered: