[tempo-distributed] Fix tempo-distributed gateway, metrics-generator and distributor rollout getting stuck when replicas==node count #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Zareichuk <[email protected]>
8osm
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
Signed-off-by: Ivan Zareichuk <[email protected]>
# Conflicts: # charts/tempo-distributed/Chart.yaml # charts/tempo-distributed/README.md
Signed-off-by: Ivan Zareichuk <[email protected]>
There was a problem hiding this comment.
Hey there @8osm Thanks for the Contribution! Have you tested it ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a rollout strategy to the gateway, metrics-generator and distributor component deployments in order to fix rollouts getting stuck when the number of nodes is equal to the number of replicas
The same rollout strategy is already present on querier, query-frontend and compactor