-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tempo-distributed] feat: add cli flag for zone aware ingestion #3230
Conversation
I get the following when trying to pass that flag.
|
@zalegrala weird, in our mimir we use this flag, but according to the Cortex Config it should be |
a899b62
to
80ad597
Compare
hm @zalegrala i looked into the jsonnet and they only set the env var |
Each database exposes different config flags, so we can't assume that because its exposed in mimir that it would be exposed in tempo. Have you had a chance to test this change? |
@zalegrala |
@zalegrala after taking another look in the jsonnet file i've realized i've missed other things in the chart (like services) |
80ad597
to
65f60a1
Compare
@zalegrala should be good now. |
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
Signed-off-by: AvivGuiser <[email protected]>
a279c3f
to
80acbf1
Compare
Signed-off-by: AvivGuiser <[email protected]>
like in mimir, we need to pass
ingester.ring.instance-availability-zone
when enabled zone aware ingestionFYI @zalegrala