[tempo-distributed] add ingress with no gateway #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrFaust92
force-pushed
the
tempo-ingress-no-gateway
branch
from
41dbc9b
to
24a54a5
Compare
DrFaust92
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
There was a problem hiding this comment.
Hey there @DrFaust92 Thanks for the contribution! Have you tested it ?
DrFaust92
force-pushed
the
tempo-ingress-no-gateway
branch
2 times, most recently
from
418e8fd
to
f26ae6f
Compare
|
yes, Sheikh-Abubaker. one "problem" is there is no way to add paths that mutate path on the backend, i.e. /jaeger/api/traces -> /api/traces, /zipkin/spans -> /spans |
DrFaust92
force-pushed
the
tempo-ingress-no-gateway
branch
from
a699c5c
to
51392a9
Compare
zanhsieh
approved these changes
Aug 10, 2024
DrFaust92
force-pushed
the
tempo-ingress-no-gateway
branch
from
4b7a40f
to
8e8d5a1
Compare
DrFaust92
force-pushed
the
tempo-ingress-no-gateway
branch
from
8e8d5a1
to
9d7493f
Compare
|
@Sheikh-Abubaker Can you review and / or merge this pr plz? |
@zanhsieh I am travelling, I'll try do it if I get time. |
DrFaust92
force-pushed
the
tempo-ingress-no-gateway
branch
from
60ee3eb
to
44f34c3
Compare
Signed-off-by: drfaust92 <[email protected]>
DrFaust92
force-pushed
the
tempo-ingress-no-gateway
branch
from
44f34c3
to
6cc2fdb
Compare
|
Sheikh-Abubaker Can you take a look at this? is it worth rebasing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3001