[tempo-distributed] Add required name label to ingesters #3315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Soelberg Heidarsson <[email protected]>
alex5517
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
|
@alex5517 is this PR intended for rollout-operator helm charts ? |
Signed-off-by: Alexander Soelberg Heidarsson <[email protected]>
|
Sorry if the PR was a bit slim on information... The PR is for the Tempo-Distributed chart. "Recently" the chart got support for deploying the the Tempo ingesters with zone awareness and to manage these new statefulsets it leverage the Grafana Rollout-Operator, but this is not working since the resulting pods from the statefulsets does not have the currently required |
alex5517
changed the title
Signed-off-by: Alexander Soelberg Heidarsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namelabel is required on pods that should be managed by the rollout-operator this pr ensure that it is added.grafana/rollout-operator#15