Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure OpenAI mixin #1092

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

mshahzeb
Copy link
Contributor

Adds a mixin for Azure OpenAI metrics.

@mshahzeb mshahzeb requested a review from a team as a code owner October 27, 2023 18:25
@mshahzeb mshahzeb marked this pull request as draft October 27, 2023 18:37
@mshahzeb
Copy link
Contributor Author

Current status and work remaining

  • All panels in dashboard right now are just stat panels, some of them have to be converted to timeseries and other panels
  • Queries for alerts need to be updated and 2 more alerts will be added
  • Will need to generate more metrics data to test dashboards / alerts

annotations: {
summary: 'High latency for Azure OpenAI calls.',
description: |||
Latency for Azure OpenAI calls on {{ $labels.resourceName }} is greater than %(alertsThresholdLatency)s%%. The currect value is {{ $value | printf "%%.2f" }}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Latency for Azure OpenAI calls on {{ $labels.resourceName }} is greater than %(alertsThresholdLatency)s%%. The currect value is {{ $value | printf "%%.2f" }}.
Latency for Azure OpenAI calls on {{ $labels.resourceName }} is greater than %(alertsThresholdLatency)s%%. The current value is {{ $value | printf "%%.2f" }}.

annotations: {
summary: 'High error for Azure OpenAI calls.',
description: |||
Error rate for Azure OpenAI calls on {{ $labels.resourceName }} is greater than %(alertsThresholdErrorRate)s%%. The currect value is {{ $value | printf "%%.2f" }}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Error rate for Azure OpenAI calls on {{ $labels.resourceName }} is greater than %(alertsThresholdErrorRate)s%%. The currect value is {{ $value | printf "%%.2f" }}.
Error rate for Azure OpenAI calls on {{ $labels.resourceName }} is greater than %(alertsThresholdErrorRate)s%%. The current value is {{ $value | printf "%%.2f" }}.

name: 'alerts-' + this.config.uid,
rules: [
{
alert: 'HighLatency',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider to add prefix all alerts with some prefix like AzureOpenAI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants