Add a dashboard utils file #819
Conversation
Signed-off-by: Callum Styan <[email protected]>
Signed-off-by: Callum Styan <[email protected]>
|
current lint failure is not from my code |
There was a problem hiding this comment.
I can see some functions differ from Mimir ones (e.g. missing resources request). If the aim is to really being consistent across the 3 DBs (which looks a good goal!) I would consider open draft PRs in the 3 respective projects to see the impact of using these utils across Mimir, Loki and Tempo.
| keepTime: true, | ||
| tags: $._config.tags, | ||
| targetBlank: false, | ||
| title: 'Loki Dashboards', |
There was a problem hiding this comment.
It looks wrong to me having "Loki" here, being this a generic util.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I'll pick this up again soon |
Keep in mind many of these have changed in Mimir since then. |
During our teams migration to memberlist we missed a few configuration bits because of the split of configuration across files and also across repos. This PR is the first step I want to take to centralize some configuration and observability across loki/mimir/tempo.
This basically takes the dashboard utils file we have in each repo and moves it to a central place, plus adding some functions to the
dashboardfunction so that things like the metric for the template var searches and the dropdown "link to other dashboards" name.Signed-off-by: Callum Styan [email protected]