-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow clean K6 object when test has failed or finished OK #276
base: main
Are you sure you want to change the base?
Allow clean K6 object when test has failed or finished OK #276
Conversation
Signed-off-by: Álvaro Aguilar <[email protected]>
Signed-off-by: Álvaro Aguilar <[email protected]>
Álvaro Aguilar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
nothing at all
Signed-off-by: Álvaro Aguilar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @aaguilartablada, apologies for such a terrible delay! Your PR never got a signed CLA: I remember thinking "let's wait until they sign before reviewing" and then apparently, I forgot about this PR since there were no new notifications 😅 Would you like to continue working on it? All contributors must sign the CLA though. |
will this pr be merged ? asking since my load test had 10 runners and some of them failed. but this led to no pods being cleanup after test duration inspite of having having the cleanup: post option in yml |
To solve the issue #275