Treat failed initializer as error (PR 291 continued) #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… also becomes Error.
|
|
|
Hello. |
yorugac
requested changes
May 20, 2024
There was a problem hiding this comment.
Hi @irumaru, thanks for picking this up 🙌 Sorry for the delay.
I think this change is fine. I'll test it a bit in coming days and if nothing comes up, I'll merge it in. Meanwhile, there's a small verbosity request for logs - please see the comment.
Co-authored-by: Olha Yevtushenko <[email protected]>
|
Thank you for your request. |
yorugac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PullRequest 291 has been out of date, and I believe that more time has passed and merging has become more difficult, so I have reworked the PR.
The changes are basically the same as in PullRequest 291, with a few modifications based on comments.
#291
Thanks to JorTurFer and yorugac.