Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPD in browser frame #3533

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Fix NPD in browser frame #3533

merged 1 commit into from
Jan 15, 2024

Conversation

ankur22
Copy link
Contributor

@ankur22 ankur22 commented Jan 11, 2024

What?

Adding grafana/xk6-browser#1152 to the v0.49.0 release notes.

Why?

To keep our users up-to-date with the new fix.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@ankur22 ankur22 requested a review from a team as a code owner January 11, 2024 14:25
@ankur22 ankur22 requested review from codebien, olegbespalov, inancgumus and ka3de and removed request for a team January 11, 2024 14:25
@ankur22 ankur22 changed the base branch from master to release-v0.49.0 January 11, 2024 14:26
@ankur22 ankur22 changed the title Fix/npd browser frame Fix NPD in browser frame Jan 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-v0.49.0@5678f9a). Click here to learn what that means.

❗ Current head f0bcfa4 differs from pull request most recent head c50e5d8. Consider uploading reports for the commit c50e5d8 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                 @@
##             release-v0.49.0    #3533   +/-   ##
==================================================
  Coverage                   ?   72.54%           
==================================================
  Files                      ?      280           
  Lines                      ?    20937           
  Branches                   ?        0           
==================================================
  Hits                       ?    15189           
  Misses                     ?     4777           
  Partials                   ?      971           
Flag Coverage Δ
ubuntu 72.49% <0.00%> (?)
windows 72.37% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ankur22 ankur22 merged commit 70f2d38 into release-v0.49.0 Jan 15, 2024
20 of 21 checks passed
@ankur22 ankur22 deleted the fix/npd-browser-frame branch January 15, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants