Remove custom 'min' function (prior to Go v1.21) #3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there is at least one more case of a Can you please go over them and check that all of them are removed now |
joanlopez
force-pushed
the
remove-custom-min
branch
from
0f146b1
to
44c779f
Compare
You are absolutely right, there were more - but apparently I'm super bad at searching on a codebase 😂 I promise I tried! |
mstoykov
approved these changes
Aug 28, 2024
mstoykov
added
the
breaking change
|
added breaking change due to us removing an exported function from lib. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It removes custom
minandmaxfunctions.Why?
Because after #3915, this is no longer needed, as these functions exist in stdlib since Go v1.21.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)