Report Cloud runs aborted by thresholds with exitcodes.ThresholdsHaveFailed

[joanlopez]

What?

It's a follow up from #3876.

It also takes into account testProgress.RunStatus == cloudapi.RunStatusAbortedThreshold as a reason for return errext.WithExitCodeIfNone(errors.New("Thresholds have been crossed"), exitcodes.ThresholdsHaveFailed).

Why?

Because when thresholds are configured with abortOnFail: true, and thresholds are crossed, then testProgress.RunStatus == cloudapi.RunStatusAbortedThreshold.

Checklist

• I have performed a self-review of my code.
• I have added tests for my changes.
• I have run linter locally (make lint) and all checks pass.
• I have run tests locally (make tests) and all tests pass.
• I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

[codebien]

@joanlopez Can you check #2804 and integrate it with the new changes if they are missing there, please?
It would be good to have it tracked as a diff like before: / after:

[joanlopez]

@joanlopez Can you check #2804 and integrate it with the new changes if they are missing there, please? It would be good to have it tracked as a diff like before: / after:

Sure, I'd be happy to do a full scan of all the scenarios mentioned there, and see if there's any quick improvement, as with ThresholdsHaveFailed. But, do you mind if I merge this pull request, and do that in another one, please?

[codebien]

@joanlopez I meant to update the issue with the changes from this current pull request. If you want to do more that's great but I didn't expect that.