Skip to content

Commit

Permalink
chore: no retries for detected_fields
Browse files Browse the repository at this point in the history
  • Loading branch information
trevorwhitney committed Sep 20, 2024
1 parent c7a471d commit 2ef80ec
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions pkg/querier/queryrange/roundtrip.go
Original file line number Diff line number Diff line change
Expand Up @@ -1237,12 +1237,12 @@ func NewDetectedFieldsTripperware(
SplitByIntervalMiddleware(schema.Configs, limits, merger, splitter, metrics.SplitByMetrics),
}

if cfg.MaxRetries > 0 {
queryRangeMiddleware = append(
queryRangeMiddleware, base.InstrumentMiddleware("retry", metrics.InstrumentMiddlewareMetrics),
base.NewRetryMiddleware(log, cfg.MaxRetries, metrics.RetryMiddlewareMetrics, metricsNamespace),
)
}
// if cfg.MaxRetries > 0 {
// queryRangeMiddleware = append(
// queryRangeMiddleware, base.InstrumentMiddleware("retry", metrics.InstrumentMiddlewareMetrics),
// base.NewRetryMiddleware(log, cfg.MaxRetries, metrics.RetryMiddlewareMetrics, metricsNamespace),
// )
// }

// detected fields is an approximation, so this is a hedge against failed requests to return
// an empty response instead of an error, in case other subqueries were successful
Expand Down

0 comments on commit 2ef80ec

Please sign in to comment.