fix: Fix for how the loop sync is done (#12941)

grafana · May 13, 2024 · 5cd850e · 5cd850e
1 parent 3cc28aa
commit 5cd850e
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/pkg/storage/stores/shipper/indexshipper/downloads/table_manager.go b/pkg/storage/stores/shipper/indexshipper/downloads/table_manager.go
@@ -111,14 +111,13 @@ func NewTableManager(cfg Config, openIndexFileFunc index.OpenIndexFileFunc, inde
 		return nil, err
 	}
 
+	// Increment the WaitGroup counter here before starting the goroutine
+	tm.wg.Add(1)
 	go tm.loop()
 	return tm, nil
 }
 
 func (tm *tableManager) loop() {
-	tm.tablesMtx.Lock()
-	tm.wg.Add(1)
-	tm.tablesMtx.Unlock()
 	defer tm.wg.Done()
 
 	syncTicker := time.NewTicker(tm.cfg.SyncInterval)