Skip to content

Commit

Permalink
Remove timeout parameter (#11102)
Browse files Browse the repository at this point in the history
**What this PR does / why we need it**:

The `helm-extra-args` causes an error with the new version of ct lint.
This change removes the timeout parameter specified in there and adds a
timeout in the CI step configuration.

**Special notes for your reviewer**:

**Checklist**
- [X] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [ ] Documentation added
- [ ] Tests updated
- [ ] `CHANGELOG.md` updated
- [ ] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [ ] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](d10549e)
- [ ] If the change is deprecating or removing a configuration option,
update the `deprecated-config.yaml` and `deleted-config.yaml` files
respectively in the `tools/deprecated-config-checker` directory.
[Example
PR](0d4416a)

Signed-off-by: Michel Hollands <[email protected]>
  • Loading branch information
MichelHollands authored Nov 1, 2023
1 parent dda698e commit 92fa3e3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/helm-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ jobs:
- name: Run chart-testing (lint)
run: ct lint --config "${CT_CONFIGFILE}" --check-version-increment=false
timeout-minutes: 10

- name: Create kind cluster
uses: helm/[email protected]
Expand Down
1 change: 0 additions & 1 deletion production/helm/ct.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,5 @@ chart-repos:
- grafana=https://grafana.github.io/helm-charts
- minio=https://charts.min.io
- prometheus-community=https://prometheus-community.github.io/helm-charts
helm-extra-args: --timeout 600s
check-version-increment: false
validate-maintainers: false

0 comments on commit 92fa3e3

Please sign in to comment.