Skip to content

Commit

Permalink
fix(blooms): Remove unused arg (#13343)
Browse files Browse the repository at this point in the history
  • Loading branch information
salvacorts authored Jun 27, 2024
1 parent 19c0509 commit fcb9b28
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion pkg/bloombuild/builder/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func New(
return nil, fmt.Errorf("error creating TSDB store: %w", err)
}

metrics := NewMetrics(r, bloomStore.BloomMetrics())
metrics := NewMetrics(r)
b := &Builder{
ID: builderID,
cfg: cfg,
Expand Down
4 changes: 1 addition & 3 deletions pkg/bloombuild/builder/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ package builder
import (
"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/promauto"

v1 "github.com/grafana/loki/v3/pkg/storage/bloom/v1"
)

const (
Expand Down Expand Up @@ -32,7 +30,7 @@ type Metrics struct {
chunkSize prometheus.Histogram
}

func NewMetrics(r prometheus.Registerer, bloomMetrics *v1.Metrics) *Metrics {
func NewMetrics(r prometheus.Registerer) *Metrics {
return &Metrics{
running: promauto.With(r).NewGauge(prometheus.GaugeOpts{
Namespace: metricsNamespace,
Expand Down

0 comments on commit fcb9b28

Please sign in to comment.