Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loki Helm Chart: Allow templating of Topology Spread Constraints #11081

Closed
kandrew5 opened this issue Oct 30, 2023 · 0 comments · Fixed by #11086 · May be fixed by #11258
Closed

Loki Helm Chart: Allow templating of Topology Spread Constraints #11081

kandrew5 opened this issue Oct 30, 2023 · 0 comments · Fixed by #11086 · May be fixed by #11258
Labels
area/helm type/feature Something new we should do

Comments

@kandrew5
Copy link
Contributor

kandrew5 commented Oct 30, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
The helm chart of Loki does not give the option to change the topologySpreadConstraints of the backend, read, write and gateway pods thus pod placement on nodes is not efficient.

Describe the solution you'd like
Provide a topologySpreadConstraints sub-section on backend, read, write and gateway statefulsets/deployment in order to have topologySpreadConstraints templated.
@JStickler JStickler added type/feature Something new we should do area/helm labels Oct 30, 2023
@kandrew5 kandrew5 mentioned this issue Oct 30, 2023
Merged
8 tasks
MichelHollands added a commit that referenced this issue Nov 1, 2023
@kandrew5 @MichelHollands
Helm: Allow topologySpreadConstraints (#11086)
303e353 
**What this PR does / why we need it**:
Allow topologySpreadConstraints for read, write, backend and gateway
statefulsets/deployments.

**Which issue(s) this PR fixes**:
Fixes #11081 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [x] Documentation added
- [ ] Tests updated
- [x] `CHANGELOG.md` updated
- [ ] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [x] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](d10549e)
- [x] If the change is deprecating or removing a configuration option,
update the `deprecated-config.yaml` and `deleted-config.yaml` files
respectively in the `tools/deprecated-config-checker` directory.
[Example
PR](0d4416a)

---------

Co-authored-by: Michel Hollands <[email protected]>
@sahmad-d2x sahmad-d2x mentioned this issue Nov 20, 2023
Open
8 tasks
rhnasc pushed a commit to inloco/loki that referenced this issue Apr 12, 2024
@kandrew5 @MichelHollands @rhnasc
Helm: Allow topologySpreadConstraints (grafana#11086)
f43705d 
**What this PR does / why we need it**:
Allow topologySpreadConstraints for read, write, backend and gateway
statefulsets/deployments.

**Which issue(s) this PR fixes**:
Fixes grafana#11081 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [x] Documentation added
- [ ] Tests updated
- [x] `CHANGELOG.md` updated
- [ ] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [x] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](grafana@d10549e)
- [x] If the change is deprecating or removing a configuration option,
update the `deprecated-config.yaml` and `deleted-config.yaml` files
respectively in the `tools/deprecated-config-checker` directory.
[Example
PR](grafana@0d4416a)

---------

Co-authored-by: Michel Hollands <[email protected]>
mraboosk pushed a commit to mraboosk/loki that referenced this issue Oct 7, 2024
@kandrew5 @MichelHollands
Helm: Allow topologySpreadConstraints (grafana#11086)
dc58831 
**What this PR does / why we need it**:
Allow topologySpreadConstraints for read, write, backend and gateway
statefulsets/deployments.

**Which issue(s) this PR fixes**:
Fixes grafana#11081 

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [x] Documentation added
- [ ] Tests updated
- [x] `CHANGELOG.md` updated
- [ ] If the change is worth mentioning in the release notes, add
`add-to-release-notes` label
- [ ] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`
- [x] For Helm chart changes bump the Helm chart version in
`production/helm/loki/Chart.yaml` and update
`production/helm/loki/CHANGELOG.md` and
`production/helm/loki/README.md`. [Example
PR](grafana@2cef71e)
- [x] If the change is deprecating or removing a configuration option,
update the `deprecated-config.yaml` and `deleted-config.yaml` files
respectively in the `tools/deprecated-config-checker` directory.
[Example
PR](grafana@0d4416a)

---------

Co-authored-by: Michel Hollands <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/helm type/feature Something new we should do
Projects
None yet
Milestone
No milestone
2 participants
@JStickler @kandrew5