Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ruler sidecar in singleBinary mode #13572

Merged

Conversation

okozachenko1203
Copy link
Contributor

What this PR does / why we need it:
support ruler sidecar in singleBinary mode

Which issue(s) this PR fixes:
Fixes #10967

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2024

CLA assistant check
All committers have signed the CLA.

@3deep5me
Copy link
Contributor

I would also need & love this feature!

@3deep5me
Copy link
Contributor

Hi @okozachenko1203,
i think you need to sign the CLA that the PR can be proceeded.

@tyriis
Copy link

tyriis commented Aug 21, 2024

would be great to have this resolved :)

@jazzlyn
Copy link

jazzlyn commented Sep 17, 2024

any chance to get this merged?

@janisii
Copy link

janisii commented Sep 23, 2024

Any updates on this?

Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trevorwhitney trevorwhitney merged commit 684baf7 into grafana:main Sep 25, 2024
65 checks passed
LashaJini pushed a commit to LashaJini/loki that referenced this pull request Sep 26, 2024
@3deep5me
Copy link
Contributor

Thanks for merging this!

Just a notice, please update the Chart.yaml in the next time. With this MR semantic versioning has been eliminated.
I had a fixed Chart-Version in ArgoCD and out of nowhere a new sidecar with new mounts appeared in my deployments.

jeschkies pushed a commit to jeschkies/loki that referenced this pull request Oct 1, 2024
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm: sidecar is not part of singleBinary
7 participants