Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Avoid looking up unnecessary TSDB symbols during Volume API #13960

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

cyriltovena
Copy link
Contributor

What this PR does / why we need it:

This avoid loading all symbols for stats queries when not needed.

❯ benchstat before.txt after.txt
name                 old time/op    new time/op    delta
TSDBIndex_Volume-16    1.10ms ± 2%    0.40ms ± 4%  -63.24%  (p=0.008 n=5+5)

name                 old alloc/op   new alloc/op   delta
TSDBIndex_Volume-16    84.8kB ± 0%    52.7kB ± 0%     ~     (p=0.079 n=4+5)

name                 old allocs/op  new allocs/op  delta
TSDBIndex_Volume-16     5.07k ± 0%     1.07k ± 0%  -78.95%  (p=0.008 n=5+5)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Comment on lines 371 to 372
for _, k := range targetLabels {
by[k] = struct{}{}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be the same as labelsToMatch. see

func prepareLabelsAndMatchersWithTargets(targetLabels []string, matchers []*labels.Matcher, tenantLabel ...string) (map[string]struct{}, []*labels.Matcher, bool) {

Copy link
Contributor

@sandeepsukhani sandeepsukhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Once this is marked as ready for review, I will do a final review.

@trevorwhitney trevorwhitney marked this pull request as ready for review August 27, 2024 22:14
@trevorwhitney trevorwhitney requested a review from a team as a code owner August 27, 2024 22:14
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, need to test in GEL with LBAC before merging.

@trevorwhitney trevorwhitney changed the title chore: Avoid looking up tsdb symbols during Volume API perf: Avoid looking up unnecessary TSDB symbols during Volume API Aug 27, 2024
@cyriltovena cyriltovena merged commit 7c1a849 into grafana:main Aug 28, 2024
62 checks passed
pascal-sochacki pushed a commit to pascal-sochacki/loki that referenced this pull request Aug 29, 2024
pascal-sochacki pushed a commit to pascal-sochacki/loki that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants