Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Avoid looking up tsdb symbols during Volume API #13981

Closed

Conversation

trevorwhitney
Copy link
Collaborator

@trevorwhitney trevorwhitney commented Aug 27, 2024

What this PR does / why we need it:

This PR is a fork of #13960, with the main difference being that it does not change the Filterer interface.

This avoid loading all symbols for volume queries when not needed.

❯ benchstat before.txt after.txt
name                 old time/op    new time/op    delta
TSDBIndex_Volume-16    1.10ms ± 2%    0.40ms ± 4%  -63.24%  (p=0.008 n=5+5)

name                 old alloc/op   new alloc/op   delta
TSDBIndex_Volume-16    84.8kB ± 0%    52.7kB ± 0%     ~     (p=0.079 n=4+5)

name                 old allocs/op  new allocs/op  delta
TSDBIndex_Volume-16     5.07k ± 0%     1.07k ± 0%  -78.95%  (p=0.008 n=5+5)

When tested in loki-dev-006 it reduced the time spend in series preparation from 640ms to 100ms, and we'd expect to see an even bigger performance improvment in ops.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney
Copy link
Collaborator Author

nevermind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants