-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: add support for configuring distributor #10531
Merged
MichelHollands
merged 1 commit into
grafana:main
from
rissson:helm-add-distributor-config
Oct 19, 2023
Merged
helm: add support for configuring distributor #10531
MichelHollands
merged 1 commit into
grafana:main
from
rissson:helm-add-distributor-config
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rissson
force-pushed
the
helm-add-distributor-config
branch
from
September 11, 2023 10:22
4f8d7ba
to
ed7f82b
Compare
github-actions
bot
added
the
type/docs
Issues related to technical documentation; the Docs Squad uses this label across many repositories
label
Sep 11, 2023
JStickler
reviewed
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] LGTM
rissson
force-pushed
the
helm-add-distributor-config
branch
from
September 15, 2023 15:55
6566a0e
to
bb5a8a6
Compare
Is this missing anything? |
rissson
force-pushed
the
helm-add-distributor-config
branch
from
September 18, 2023 09:03
bb5a8a6
to
260ff79
Compare
Signed-off-by: Marc 'risson' Schmitt <[email protected]>
rissson
force-pushed
the
helm-add-distributor-config
branch
from
October 18, 2023 15:34
260ff79
to
e2c5d51
Compare
MichelHollands
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
**What this PR does / why we need it**: Add support for configuring distributor with Helm. Needed to be able to enable IPv6 on that component. **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [x] N/A: Tests updated - [x] `CHANGELOG.md` updated - [x] N/A: If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [x] N/A: Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@d10549e) Signed-off-by: Marc 'risson' Schmitt <[email protected]>
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
**What this PR does / why we need it**: Add support for configuring distributor with Helm. Needed to be able to enable IPv6 on that component. **Which issue(s) this PR fixes**: Fixes #<issue number> **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [x] N/A: Tests updated - [x] `CHANGELOG.md` updated - [x] N/A: If the change is worth mentioning in the release notes, add `add-to-release-notes` label - [x] N/A: Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` - [x] For Helm chart changes bump the Helm chart version in `production/helm/loki/Chart.yaml` and update `production/helm/loki/CHANGELOG.md` and `production/helm/loki/README.md`. [Example PR](grafana@2cef71e) Signed-off-by: Marc 'risson' Schmitt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add support for configuring distributor with Helm. Needed to be able to enable IPv6 on that component.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PR