Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm: Allow to define resources for GrafanaAgent pods #11851

Merged
merged 20 commits into from
Feb 14, 2024
Merged

Helm: Allow to define resources for GrafanaAgent pods #11851

merged 20 commits into from
Feb 14, 2024

Conversation

elcomtik
Copy link
Contributor

@elcomtik elcomtik commented Feb 1, 2024

What this PR does / why we need it:
Helm: Allow to define grafana-agent resource requests in Loki chart values

Which issue(s) this PR fixes:
Fixes #10223

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@elcomtik elcomtik requested a review from a team as a code owner February 1, 2024 15:09
@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Feb 1, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 2, 2024
@elcomtik
Copy link
Contributor Author

elcomtik commented Feb 5, 2024

@MichelHollands could you please review this?

@elcomtik
Copy link
Contributor Author

@MichelHollands could you please review this?

MichelHollands
MichelHollands reviewed Feb 14, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
production/helm/loki/CHANGELOG.md Outdated Show resolved Hide resolved
@elcomtik
Copy link
Contributor Author

Fixed readme, should be GTG.

MichelHollands
MichelHollands approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichelHollands MichelHollands merged commit 6879788 into grafana:main Feb 14, 2024
11 checks passed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@elcomtik @MichelHollands @rhnasc
Helm: Allow to define resources for GrafanaAgent pods (grafana#11851)
038be4d 
Co-authored-by: Michel Hollands <[email protected]>
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
@elcomtik @MichelHollands
Helm: Allow to define resources for GrafanaAgent pods (grafana#11851)
7075b63 
Co-authored-by: Michel Hollands <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbaldry jdbaldry jdbaldry left review comments

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
area/helm size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to define grafana-agent resource requests in Loki chart values
3 participants
@elcomtik @jdbaldry @MichelHollands