Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow to configure http_config for ruler #12113

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

sebhoss
Copy link
Contributor

@sebhoss sebhoss commented Mar 3, 2024

What this PR does / why we need it:

This allows to configure http_config in the ruler section.

Which issue(s) this PR fixes:
Fixes #12112

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@sebhoss sebhoss requested a review from a team as a code owner March 3, 2024 10:42
@CLAassistant
Copy link

CLAassistant commented Mar 3, 2024

CLA assistant check
All committers have signed the CLA.

@JStickler
Copy link
Contributor

@sebhoss Could you please also update the Helm chart version in the README and resolve conflicts for the CHANGELOG and Chart?

@sebhoss
Copy link
Contributor Author

sebhoss commented Mar 13, 2024

@JStickler yep done - thanks! .. and sorry for closing/re-opening this PR .. I'm kinda bad with buttons today 😅

@sebhoss sebhoss force-pushed the main branch 2 times, most recently from 64ee7ad to 2ce148f Compare March 14, 2024 15:52
@sebhoss
Copy link
Contributor Author

sebhoss commented Mar 14, 2024

Rebased on latest main

@MichelHollands MichelHollands changed the title allow to configure http_config for ruler feat: allow to configure http_config for ruler Mar 14, 2024
@sebhoss
Copy link
Contributor Author

sebhoss commented Mar 14, 2024

@MichelHollands thanks! I just pushed a new change to fix the commit message. Since the original ticket was classified as bug I used 'fix' instead of 'feat' here though..

@MichelHollands MichelHollands changed the title feat: allow to configure http_config for ruler fix: allow to configure http_config for ruler Mar 14, 2024
@MichelHollands MichelHollands merged commit f0cf65b into grafana:main Mar 14, 2024
13 checks passed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Signed-off-by: Sebastian Hoß <[email protected]>
Co-authored-by: Michel Hollands <[email protected]>
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
Signed-off-by: Sebastian Hoß <[email protected]>
Co-authored-by: Michel Hollands <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm chart ignores http_config for ruler storage configuration
4 participants