-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow to configure http_config for ruler #12113
Conversation
@sebhoss Could you please also update the Helm chart version in the README and resolve conflicts for the CHANGELOG and Chart? |
@JStickler yep done - thanks! .. and sorry for closing/re-opening this PR .. I'm kinda bad with buttons today 😅 |
64ee7ad
to
2ce148f
Compare
Rebased on latest main |
fixes grafana#12112 Signed-off-by: Sebastian Hoß <[email protected]>
@MichelHollands thanks! I just pushed a new change to fix the commit message. Since the original ticket was classified as bug I used 'fix' instead of 'feat' here though.. |
Signed-off-by: Sebastian Hoß <[email protected]> Co-authored-by: Michel Hollands <[email protected]>
Signed-off-by: Sebastian Hoß <[email protected]> Co-authored-by: Michel Hollands <[email protected]>
What this PR does / why we need it:
This allows to configure
http_config
in the ruler section.Which issue(s) this PR fixes:
Fixes #12112
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR