Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: helm: Add headless service to bloom-gateway #12562

Merged
merged 2 commits into from
Apr 11, 2024
Merged

chore: helm: Add headless service to bloom-gateway #12562

merged 2 commits into from
Apr 11, 2024

Conversation

DylanGuedes
Copy link
Contributor

@DylanGuedes DylanGuedes commented Apr 10, 2024 •
edited
Loading

What this PR does / why we need it:
Add a headless service to bloom-gateway.
you can then configure the bloom-gateway client to use it the following way:

bloom_gateway:
  client:
    addresses: dnssrv+_bloom-gateway-grpc._tcp.bloom-gateway-headless.my-namespace.svc.cluster.local.

@DylanGuedes DylanGuedes changed the title helm: Add headless service to bloom-gateway chore: helm: Add headless service to bloom-gateway Apr 10, 2024
@DylanGuedes DylanGuedes marked this pull request as ready for review April 10, 2024 17:01
@DylanGuedes DylanGuedes requested a review from a team as a code owner April 10, 2024 17:01
MichelHollands
MichelHollands approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DylanGuedes DylanGuedes merged commit c4aa6ea into main Apr 11, 2024
13 checks passed
@DylanGuedes DylanGuedes deleted the add-headlesservice-to-bloomgateway branch April 11, 2024 12:57
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@DylanGuedes @rhnasc
chore: helm: Add headless service to bloom-gateway (grafana#12562)
bf83a59
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
@DylanGuedes
chore: helm: Add headless service to bloom-gateway (grafana#12562)
0bb8876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
area/helm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DylanGuedes @MichelHollands