Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: helm: Set compactor addr for distributed mode. #12748

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix: helm: Set compactor addr for distributed mode. #12748

merged 1 commit into from
Apr 23, 2024

Conversation

DylanGuedes
Copy link
Contributor

@DylanGuedes DylanGuedes commented Apr 23, 2024 •
edited
Loading

What this PR does / why we need it:
Fix the compactor address for when mode=distributed.

Which issue(s) this PR fixes:
Fixes #12646

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@DylanGuedes DylanGuedes requested a review from a team as a code owner April 23, 2024 10:39
MichelHollands
MichelHollands approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DylanGuedes DylanGuedes merged commit 521d40a into main Apr 23, 2024
59 of 60 checks passed
@DylanGuedes DylanGuedes deleted the fix-compactor-address branch April 23, 2024 12:31
mattgialelis pushed a commit to mattgialelis/loki that referenced this pull request Apr 23, 2024
@DylanGuedes @mattgialelis
fix: helm: Set compactor addr for distributed mode. (grafana#12748)
9e4f29d
@loki-gh-app loki-gh-app bot mentioned this pull request Apr 29, 2024
Closed
This was referenced May 6, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request May 20, 2024
Closed
This was referenced May 27, 2024
Closed
Closed
This was referenced Jun 10, 2024
Closed
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Closed
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Open
This was referenced Jul 3, 2024
Closed
Closed
Closed
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
@DylanGuedes
fix: helm: Set compactor addr for distributed mode. (grafana#12748)
978572d
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
area/helm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm: Incorrect compactor address with deploymentMode: Distributed
2 participants
@DylanGuedes @MichelHollands