Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [k200] fix(blooms): dont break iterator conventions #12834

Merged
merged 1 commit into from
Apr 30, 2024
Merged

chore: [k200] fix(blooms): dont break iterator conventions #12834

merged 1 commit into from
Apr 30, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport 1665e85 from #12808

Followup to #12806 which exposes skipped pages more explicitly than as an error.

  • refactors skip logic for bloom pages that are too large
  • s/Seek/LoadOffset/ for LazyBloomIter
  • removes unused code

@owen-d @grafana-delivery-bot
fix(blooms): dont break iterator conventions (#12808)
957d6a4 
Followup to #12806 which exposes skipped pages more explicitly than as an error.

* refactors skip logic for bloom pages that are too large
* s/Seek/LoadOffset/ for LazyBloomIter
* removes unused code

(cherry picked from commit 1665e85)
@grafanabot grafanabot requested a review from a team as a code owner April 30, 2024 10:45
@grafanabot grafanabot added backport size/L type/bug Somehing is not working as expected labels Apr 30, 2024
@grafanabot grafanabot requested a review from chaudum April 30, 2024 10:45
@chaudum chaudum merged commit 9daf9fd into k200 Apr 30, 2024
62 checks passed
@chaudum chaudum deleted the backport-12808-to-k200 branch April 30, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaudum chaudum chaudum approved these changes

Assignees
No one assigned
Labels
backport size/L type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grafanabot @chaudum @owen-d