Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Backport 12915 to release 3.0.x #12917

Merged
merged 2 commits into from
May 8, 2024
Merged

docs: Backport 12915 to release 3.0.x #12917

merged 2 commits into from
May 8, 2024

Conversation

DylanGuedes
Copy link
Contributor

What this PR does / why we need it:
backport #12915

@DylanGuedes
chore: Call shardstreams.Config by value instead of by reference (#…
8c50692 
…12915)

Use `shardstreams.Config` by value instead of by reference to fix docs generation.
Our `docs-generator` tool relies on the struct address/references to assume that flags are present. Using this config by value fixes it.

(cherry picked from commit afd9e36)
@DylanGuedes
remove unavailable config
215256b
@DylanGuedes DylanGuedes requested a review from a team as a code owner May 8, 2024 13:10
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label May 8, 2024
@DylanGuedes DylanGuedes changed the title Backport 12915 to release 3.0.x docs: Backport 12915 to release 3.0.x May 8, 2024
MichelHollands
MichelHollands approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JStickler JStickler merged commit aabd9e3 into release-3.0.x May 8, 2024
53 checks passed
@JStickler JStickler deleted the backport-12915-to-release-3.0.x branch May 8, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelHollands MichelHollands MichelHollands approved these changes

Assignees
No one assigned
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DylanGuedes @MichelHollands @JStickler