Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [k205] fix: Do not filter out chunks for store when From==Through and From==start #13121

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport d9cc513 from #13117


What this PR does / why we need it:

This PR fixes a bug where chunks are incorrectly filtered out when their From timestamp is equal to their Through timestamp (which happens when there is a single log line) and the From timestamp is equal to the from time of the of the request.

How to reproduce:

  1. Insert a single log line with a timestamp exactly at point of an hour
  2. Flush ingester
  3. Query log line with a split interval of 1h

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

  • In a query range, the From is inclusive and the Through is exclusive
  • In a ChunkRef, both From and Through are inclusive, because Through represents the timestamp of the last log line in the chunk.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

…m==start` (#13117)

This PR fixes a bug where chunks are incorrectly filtered out when their `From` timestamp is equal to their `Through` timestamp (which happens when there is a single log line) and the `From` timestamp is equal to the `from` time of the of the request.

How to reproduce:

1. Insert a single log line with a timestamp exactly at point of an hour
2. Flush ingester
3. Query log line with a split interval of 1h

Signed-off-by: Christian Haudum <[email protected]>
Co-authored-by: Ed Welch <[email protected]>
(cherry picked from commit d9cc513)
@grafanabot grafanabot requested a review from a team as a code owner June 4, 2024 16:39
@grafanabot grafanabot added backport size/S type/bug Somehing is not working as expected labels Jun 4, 2024
@grafanabot grafanabot requested a review from chaudum June 4, 2024 16:39
@chaudum chaudum merged commit 6e66e68 into k205 Jun 4, 2024
62 checks passed
@chaudum chaudum deleted the backport-13117-to-k205 branch June 4, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/S type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants