-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update Loki monitoring docs to new meta monitoring helm #13176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team]
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md
Outdated
Show resolved
Hide resolved
…-cloud.md Co-authored-by: J Stickler <[email protected]>
…-cloud.md Co-authored-by: J Stickler <[email protected]>
…-cloud.md Co-authored-by: J Stickler <[email protected]>
…-cloud.md Co-authored-by: J Stickler <[email protected]>
…onitoring.md Co-authored-by: J Stickler <[email protected]>
…onitoring.md Co-authored-by: J Stickler <[email protected]>
…onitoring.md Co-authored-by: J Stickler <[email protected]>
…onitoring.md Co-authored-by: J Stickler <[email protected]>
Hi @JStickler, good catches that should be both of those sections updated and thank you for making the direct changes to the other parts. All accepted! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] Round two.
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md
Outdated
Show resolved
Hide resolved
Committing Suggestions made by Julie Co-authored-by: J Stickler <[email protected]>
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much cleaner. I think we can probably get this merged today.
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-grafana-cloud.md
Outdated
Show resolved
Hide resolved
docs/sources/setup/install/helm/monitor-and-alert/with-local-monitoring.md
Outdated
Show resolved
Hide resolved
This PR must be merged before a backport PR will be created. |
Co-authored-by: J Stickler <[email protected]>
Co-authored-by: J Stickler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[docs team] LGTM
Co-authored-by: J Stickler <[email protected]> (cherry picked from commit b4d44f8)
Updated the Loki monitoring documentation to use the new meta-monitoring repo.
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR