perf(blooms): mempool no longer zeroes out buffers unnecessarily #13282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dramatically improves the speed of mempool usage. I noticed some code in the mempool which iterated over buffers on every
get()
call. Guessing this to be expensive, I added a few benchmarks -- this is one of those rare-100%
speed improvements. The reason this is safe because only the length of the provided[]byte
is important -- NOT it's contents. I verified this everywhere it was used (I knew this was the expected contract already), added some benchmarks, and we saw a great improvement.