Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/promtail.sh: remove useless option #133

Closed
wants to merge 3 commits into from

Conversation

daixiang0
Copy link
Contributor

As comment said, the namespace option is useless, so remove it.

Signed-off-by: Xiang Dai [email protected]

@DanCech
Copy link
Contributor

DanCech commented Dec 17, 2018

The yaml produced by ksonnet includes the namespace entry for the promtail ClusterRoleBinding. If we update the ksonnet to not produce that then it can (and should) be removed here. Because we want to produce promtail.sh from the ksonnet yaml output, we don't want to remove it here while it is still being output by the ksonnet.

@daixiang0
Copy link
Contributor Author

$ cd production
$ git grep ClusterRoleBinding
helm/templates/promtail/clusterrolebinding.yaml:2:kind: ClusterRoleBinding

there is not ClusterRoleBinding in ksonnet now.

Copy link
Contributor

@DanCech DanCech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that the yaml matches what's produced by ksonnet, this is fine with me.

@daixiang0
Copy link
Contributor Author

any update?

@tomwilkie
Copy link
Contributor

Sorry @daixiang0, been busy. Need a rebase.

@daixiang0
Copy link
Contributor Author

@tomwilkie rebase done, thanks

@daixiang0 daixiang0 closed this Jan 18, 2019
@daixiang0 daixiang0 deleted the fix-namespace-issue branch January 18, 2019 01:42
periklis pushed a commit to periklis/loki that referenced this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants