-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/promtail.sh: remove useless option #133
Conversation
b9c4af6
to
ad8ca5d
Compare
The yaml produced by ksonnet includes the namespace entry for the |
Signed-off-by: Xiang Dai <[email protected]>
there is not |
ad8ca5d
to
3dfb6bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that the yaml matches what's produced by ksonnet, this is fine with me.
any update? |
Sorry @daixiang0, been busy. Need a rebase. |
@tomwilkie rebase done, thanks |
[release-5.7] Backport PR grafana#9433
As comment said, the namespace option is useless, so remove it.
Signed-off-by: Xiang Dai [email protected]