Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avg function result int unexpected response #13357

Conversation

yincongcyincong
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #12176 #13287
avg_over_time function don't contain default group , then an error output.

error code line:
https://github.com/grafana/loki/blob/main/pkg/logql/evaluator.go#L390

@yincongcyincong yincongcyincong requested a review from a team as a code owner July 1, 2024 05:17
@yincongcyincong yincongcyincong changed the title avg function result int unexpected response fix: avg function result int unexpected response Jul 1, 2024
@cyriltovena
Copy link
Contributor

cc @ashwanthgoli

@ashwanthgoli
Copy link
Contributor

@yincongcyincong thanks for the contribution ❤️ really appreciate it.
But I am closing this in the favour of an earlier pr #12176 that fixes the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants