chore: [k209] fix(sharding): use without() grouping when merging avg_over_time
shard results
#13359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport eb8a363 from #12176
What this PR does / why we need it:
avg_over_time
expression that uses eitherkeep
orlabel_format
stage without any aggregation fails on main with the following error:aggregation operator '"sum"' without grouping
Given these expressions contain stages that could reduce the labelset, sharding converts it to the following form
sum (sum_over_time()) / sum(count_over_time())
, but vector aggregation expr evaluator always expects a grouping. This pr updates theavg_over_time
shard mapper to usewithout()
grouping for generating vector agg expr when it is not explicitly set.example query to reproduce this error:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR