Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): Add support for the volume API #13369

Merged
merged 14 commits into from
Jul 3, 2024
Merged

Conversation

jatinsu
Copy link
Contributor

@jatinsu jatinsu commented Jul 1, 2024

What this PR does / why we need it:
This PR enables the volume API.

Which issue(s) this PR fixes:
None

Special notes for your reviewer:
cc @periklis

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@CLAassistant
Copy link

CLAassistant commented Jul 1, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides fixing the unit tests, we need to expose the new limit in the LokiStack CRD.

@periklis periklis changed the title feat: Enable The Volume API for Openshift feat(operator): Add support for the volume API Jul 2, 2024
@pull-request-size pull-request-size bot added size/M and removed size/XS labels Jul 2, 2024
Copy link
Collaborator

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Please run make bundle-all to generate all CRDs and bundles.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 2, 2024
Copy link
Collaborator

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing, missing rendering in internal/manifests/internal/config/loki-runtime-config.yaml for overriding maxVolumeSeries per tenant

@periklis periklis merged commit d451e23 into grafana:main Jul 3, 2024
68 checks passed
periklis pushed a commit to periklis/loki that referenced this pull request Jul 3, 2024
periklis pushed a commit to periklis/loki that referenced this pull request Jul 3, 2024
periklis pushed a commit to periklis/loki that referenced this pull request Jul 3, 2024
periklis pushed a commit to periklis/loki that referenced this pull request Jul 3, 2024
openshift-merge-bot bot added a commit to openshift/loki that referenced this pull request Jul 3, 2024
openshift-merge-bot bot added a commit to openshift/loki that referenced this pull request Jul 3, 2024
periklis pushed a commit to periklis/loki that referenced this pull request Jul 3, 2024
periklis added a commit to openshift/loki that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants