-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): Replace bloom compactor with bloom planner and builder #14003
Conversation
7f1f09d
to
10f67f0
Compare
Signed-off-by: Christian Haudum <[email protected]>
This is PR is part of the process of removing the bloom compactor and replace it with bloom planner and bloom builder. See also #13957 Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
10f67f0
to
73709a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. this adds a lot though so can we bump the version number?
Signed-off-by: Christian Haudum <[email protected]>
Done. Can you check once more? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Please revert this change, there are multiple problems with bloom-builder, that affect not only bloom filter feature:
...but also break general chart usability: |
#14128 contains fixes for the issues mentioned above. |
…rafana#14003) This is PR is part of the process of removing the bloom compactor and replace it with bloom planner and bloom builder. Part of grafana#13957 Signed-off-by: Christian Haudum <[email protected]>
What this PR does / why we need it:
This is PR is part of the process of removing the bloom compactor and replace it with bloom planner and bloom builder.
Special notes for your reviewer:
Part of #13957
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR