Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): Replace bloom compactor with bloom planner and builder #14003

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Aug 29, 2024

What this PR does / why we need it:

This is PR is part of the process of removing the bloom compactor and replace it with bloom planner and bloom builder.

Special notes for your reviewer:

Part of #13957

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@chaudum chaudum force-pushed the chaudum/replace-bloom-compactor-helm-chart branch from 7f1f09d to 10f67f0 Compare August 30, 2024 06:28
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Aug 30, 2024
This is PR is part of the process of removing the bloom compactor and
replace it with bloom planner and bloom builder.

See also #13957

Signed-off-by: Christian Haudum <[email protected]>
Signed-off-by: Christian Haudum <[email protected]>
@chaudum chaudum force-pushed the chaudum/replace-bloom-compactor-helm-chart branch from 10f67f0 to 73709a9 Compare September 2, 2024 12:05
@chaudum chaudum marked this pull request as ready for review September 2, 2024 12:05
@chaudum chaudum requested a review from a team as a code owner September 2, 2024 12:05
Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. this adds a lot though so can we bump the version number?

Signed-off-by: Christian Haudum <[email protected]>
@chaudum
Copy link
Contributor Author

chaudum commented Sep 3, 2024

looks good. this adds a lot though so can we bump the version number?

Done. Can you check once more?

Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaudum chaudum merged commit 08e61ca into main Sep 3, 2024
63 checks passed
@chaudum chaudum deleted the chaudum/replace-bloom-compactor-helm-chart branch September 3, 2024 15:40
@z0rc
Copy link

z0rc commented Sep 10, 2024

@chaudum
Copy link
Contributor Author

chaudum commented Sep 10, 2024

Hi @z0rc @diranged I'm sorry for any inconvenience this PR caused and I appreciate your reports. We will try to get issues sorted as soon as my availability allows for it. Any help with PRs is welcome.

@chaudum
Copy link
Contributor Author

chaudum commented Sep 12, 2024

#14128 contains fixes for the issues mentioned above.

mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
…rafana#14003)

This is PR is part of the process of removing the bloom compactor and replace it with bloom planner and bloom builder.

Part of grafana#13957

Signed-off-by: Christian Haudum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm size/XXL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants