chore(operator): Upgrade operator-sdk 1.37.0 and kind 0.23.0 #14445
+269
−861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
periklis
requested review from
xperimental,
JoaoBraveCoding and
a team
as code owners
| @@ -7,7 +7,7 @@ spec: | |||
| spec: | |||
| containers: | |||
| - name: kube-rbac-proxy | |||
| image: gcr.io/kubebuilder/kube-rbac-proxy:v0.15.0 | |||
| image: gcr.io/kubebuilder/kube-rbac-proxy:v0.16.0 | |||
There was a problem hiding this comment.
Why was this also updated? And why v0.16.0? It seems like v0.18.0 is the one aligned with k8s v1.30
There was a problem hiding this comment.
@JoaoBraveCoding Following the migration steps from v1.33 up to v1.37 I was instructed to update to v0.16 here: https://sdk.operatorframework.io/docs/upgrading-sdk-version/v1.36.0/
You say [email protected] is using the [email protected] client-go/api then we can update to this one too. I need to double check what version we issue on OCP v4.17 though.
There was a problem hiding this comment.
I see! Yes according to the release notes that seems to be the case https://github.com/brancz/kube-rbac-proxy/releases
periklis
added a commit
to periklis/loki
that referenced
this pull request
Oct 18, 2024
periklis
added a commit
to openshift/loki
that referenced
this pull request
Oct 18, 2024
[release-6.0] Backport PR grafana#14445
periklis
added a commit
to periklis/loki
that referenced
this pull request
Oct 21, 2024
[release-6.0] Backport PR grafana#14445
openshift-merge-bot bot
added a commit
to openshift/loki
that referenced
this pull request
Oct 24, 2024
[release-5.9] Backport PR grafana#14445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Follow up on #14416 to upgrade the used
operator-sdkandkindfor local development.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR