Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(operator): Fix make build target for size-calculator #14551

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix(operator): Fix make build target for size-calculator #14551

merged 1 commit into from
Oct 21, 2024
+1 −1

Conversation

periklis
Copy link
Collaborator

What this PR does / why we need it:
Fix path in make file target to build the experimental operator size-calculator

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@periklis periklis self-assigned this Oct 21, 2024
JoaoBraveCoding
JoaoBraveCoding approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JoaoBraveCoding JoaoBraveCoding merged commit e727187 into grafana:main Oct 21, 2024
70 checks passed
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoBraveCoding JoaoBraveCoding JoaoBraveCoding approved these changes

@xperimental xperimental Awaiting requested review from xperimental xperimental is a code owner

Assignees

@periklis periklis

Labels
sig/operator size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@periklis @JoaoBraveCoding