start and stop modules in correct order #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting up, start all dependencies first then start the target module. When stopping, reverse the order to ensure we dont try and stop a module while there is still something running that needs it. fixes #105
tomwilkie
reviewed
Feb 5, 2019
tomwilkie
reviewed
Feb 5, 2019
tomwilkie
reviewed
Feb 5, 2019
tomwilkie
reviewed
Feb 5, 2019
tomwilkie
reviewed
Feb 5, 2019
tomwilkie
reviewed
Feb 5, 2019
tomwilkie
reviewed
Feb 5, 2019
tomwilkie
reviewed
Feb 5, 2019
woodsaj
force-pushed
the
issue105
branch
2 times, most recently
from
3c82807
to
ab13a69
Compare
tomwilkie
reviewed
Feb 5, 2019
pkg/loki/loki.go
Outdated
| } | ||
| delete(t.inited, m) |
There was a problem hiding this comment.
I guess the inited field can be removed completely from the Loki struct
tomwilkie
reviewed
Feb 5, 2019
pkg/loki/modules.go
Outdated
| uniq[dep] = false | ||
| } | ||
|
|
||
| result := make([]moduleName, 0) |
There was a problem hiding this comment.
Lets do []moduleName{} or make([]moduleName, 0, len(uniq). Anything but this!
|
LGTM with 2 nits. |
tomwilkie
approved these changes
Feb 5, 2019
btaani
pushed a commit
to btaani/loki
that referenced
this pull request
Apr 22, 2024
[release-5.7] Improve validation of provided S3 storage configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting up, start all dependencies first then start the target
module. When stopping, reverse the order to ensure we dont try and
stop a module while there is still something running that needs it.
fixes #105