bugfix:add cases.NoLower option

[wujunwei]

What this PR does / why we need it:
see #7048
if we don't apply cases.NoLower, it will upper first alphabet lower the others

package main

import (
	"fmt"
	"golang.org/x/text/cases"
	"golang.org/x/text/language"
	"strings"
)

func main() {
	source := "testAPI"
	fmt.Println(cases.Title(language.Und).String(source)) // out: Testapi
	fmt.Println(cases.Title(language.Und, cases.NoLower).String(source)) // out: TestAPI
	fmt.Println(strings.Title(source)) // out: TestAPI
}

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

• Documentation added
• Tests updated
• Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
• Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

[grafanabot]

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

[kavirajk]

Thanks @wujunwei. Can you please add a small test to lock this behaviour?

[wujunwei]

Thanks @wujunwei. Can you please add a small test to lock this behaviour?

I 'd like to do that , something like this ?

        source := "testAPI"
        assert.Equal(t,cases.Title(language.Und, cases.NoLower).String(source), strings.Title(source))
        assert.NotEqual(t,cases.Title(language.Und).String(source), strings.Title(source))

[kavirajk]

I 'd like to do that , something like this ?
source := "testAPI"
assert.Equal(t,cases.Title(language.Und, cases.NoLower).String(source), strings.Title(source))
assert.NotEqual(t,cases.Title(language.Und).String(source), strings.Title(source))

No. not really.

I mean we should test how we use it in Loki pkg/util/cfg/flag.go

Can you add a test case in flag_test.go?

[wujunwei]

No. not really.

I mean we should test how we use it in Loki pkg/util/cfg/flag.go

Can you add a test case in flag_test.go?

Thanks for explaining. I have add some test case , Please take a look :)

[kavirajk]

Thanks @wujunwei for addressing the feedback. LGTM 👍

Looks like CI is failing for some unrelated reasons. Can you please rebase your branch to main? I will merge it then.

[grafanabot]

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

[wujunwei]

Have done so :) .