Update comments on ingester ScaledObject. (#9352)

Signed-off-by: Peter Štibraný <[email protected]>
grafana · Sep 20, 2024 · 5e15310 · 5e15310
1 parent 6c4f733
commit 5e15310
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/operations/mimir/ingest-storage-ingester-autoscaling.libsonnet b/operations/mimir/ingest-storage-ingester-autoscaling.libsonnet
@@ -119,8 +119,7 @@
         advanced: {
           horizontalPodAutoscalerConfig: {
             behavior: {
-              // Allow 100% upscaling of pods if scale up is indicated for 10 minutes to see effects of scaling faster.
-              // Use a lookback period of 30 minutes, which will only upscale to the min(requestedReplicas) over that period
+              // Allow 100% upscaling of pods every 10 minutes to the min value of desired replicas over last 30 minutes.
               scaleUp: {
                 policies: [
                   {
@@ -129,19 +128,18 @@
                     periodSeconds: $.util.parseDuration('10m'),
                   },
                 ],
-                selectPolicy: 'Min',
+                selectPolicy: 'Min',  // This would only have effect if there were multiple policies.
                 stabilizationWindowSeconds: $.util.parseDuration('30m'),
               },
-              // Allow 10% downscaling of pods if scale down is indicated for 30 minutes.
-              // Use a lookback period of 60 minutes, which will only downscale to the max(requestedReplicas) over that period
+              // Allow 10% downscaling of pods every 30 minutes to the max value of desired replicas over last 60 minutes.
               scaleDown: {
                 policies: [{
                   type: 'Percent',
                   value: 10,
                   periodSeconds: $.util.parseDuration('30m'),
                 }],
-                selectPolicy: 'Max',
-                stabilizationWindowSeconds: $.util.parseDuration('1h'),  // We can't go higher than 1h.,
+                selectPolicy: 'Max',  // This would only have effect if there were multiple policies.
+                stabilizationWindowSeconds: $.util.parseDuration('1h'),
               },
             },
           },