Jsonnet: Fix ruler-querier CPU threshold #3520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhesketh can you please verify whether my thinking is correct here? |
pracucci
approved these changes
Nov 24, 2022
jhesketh
approved these changes
Nov 25, 2022
| ruler_querier_container+:: | ||
| // Test a <1 non-integer CPU request, to verify that this gets converted into an integer for | ||
| // the KEDA threshold | ||
| k.util.resourcesRequests(0.2, '1Gi'), |
There was a problem hiding this comment.
eg, does this still work if we supply "1" or "0.2" etc.
There was a problem hiding this comment.
Thanks @jhesketh - I've changed the CPU request into '0.2' along with a comment that we're testing using a string, to make sure it works.
In auto-scaling Jsonnet logic, fix ruler-querier CPU threshold so it's a string encoded integer millicores value. Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
bugfix/autoscaling-milli-cpu
branch
from
687cf90
to
974f2f8
Compare
masonmei
pushed a commit
to udmire/mimir
that referenced
this pull request
Dec 16, 2022
* Jsonnet: Fix ruler-querier CPU threshold In auto-scaling Jsonnet logic, fix ruler-querier CPU threshold so it's a string encoded integer millicores value. Signed-off-by: Arve Knudsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In auto-scaling Jsonnet logic, fix ruler-querier CPU threshold so it's a string encoded integer millicores value.
Which issue(s) this PR fixes or relates to
After my recent auto-scaling fix, I realized that the ruler-querier component may supply KEDA with a decimal CPU threshold, while it requires an integer.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]