Add query-frontend config option to log request headers in query logs #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr00se
changed the title
pr00se
force-pushed
the
frontend-log-headers
branch
2 times, most recently
from
58f455f
to
446839b
Compare
56quarters
reviewed
May 17, 2023
pr00se
force-pushed
the
frontend-log-headers
branch
from
446839b
to
1141a6b
Compare
colega
approved these changes
May 18, 2023
This was referenced Dec 9, 2023
dannykopping
pushed a commit
to grafana/loki
that referenced
this pull request
Jan 22, 2024
…1499) **What this PR does / why we need it**: Adding feature present in mimir, specifically grafana/mimir#5030. Adds a config option to the query-frontend to specify a list of request headers to include in query logs. For example, setting -frontend.log-query-request-headers="X-Grafana-Org-Id" and sending a query with X-Grafana-Org-Id:1 results in query log lines that include header_x_grafana_org_id=1. **Which issue(s) this PR fixes**: Fixes #11422
3 tasks
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
…afana#11499) **What this PR does / why we need it**: Adding feature present in mimir, specifically grafana/mimir#5030. Adds a config option to the query-frontend to specify a list of request headers to include in query logs. For example, setting -frontend.log-query-request-headers="X-Grafana-Org-Id" and sending a query with X-Grafana-Org-Id:1 results in query log lines that include header_x_grafana_org_id=1. **Which issue(s) this PR fixes**: Fixes grafana#11422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a config option to the query-frontend to specify a list of request headers to include in query logs.
For example, setting
-query-frontend.log-query-request-headers="X-Grafana-Org-Id"and sending a query withX-Grafana-Org-Id:1results in query log lines that includeheader_x_grafana_org_id=1.Which issue(s) this PR fixes or relates to
Fixes #4815
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]