objtools: fix 5GiB+ server-side copies on S3 #8427
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
S3 only allows
CopyObject
to be used on objects <= 5GiB in size (docs). This limitation was encountered when trying to useundelete-blocks
on a large block (I anonymized object information):This fix works around this by first checking the object to be copied with a
HEAD
request to find out its size. If it is small enough to be copied withCopyObject
it is. Otherwise if it is too large then a multipart upload is used where each part is an increasing byte range of the object. Minio unfortunately adds an unnecessaryHEAD
request for each part, but there's no way to work around that while using their client.Opening as a draft until this is manually tested.
Which issue(s) this PR fixes or relates to
Fixes https://github.com/grafana/mimir-squad/issues/2163
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.