WIP: Not for merging and please ignore. #8996
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotjosh
force-pushed
the
dimitar/ingester/consume-latency-push-sharding
branch
from
05eae9e
to
0d4a616
Compare
dimitarvdimitrov
force-pushed
the
dimitar/ingester/consume-latency-push-sharding
branch
from
16f8a12
to
e28dbab
Compare
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
* kafka replay speed: adjust batchingQueueCapacity I made 2000 up when we were flushing individual series to the channel. Then 2000 might have made sense, but when flushing whole WriteRequests a capacity of 1 should be sufficient. Signed-off-by: Dimitar Dimitrov <[email protected]> * Increase errCh capacity Signed-off-by: Dimitar Dimitrov <[email protected]> * Explain why +1 Signed-off-by: Dimitar Dimitrov <[email protected]> * Set capacity to 5 Signed-off-by: Dimitar Dimitrov <[email protected]> * Update pkg/storage/ingest/pusher.go Co-authored-by: gotjosh <[email protected]> * Improve test Signed-off-by: Dimitar Dimitrov <[email protected]> * Update pkg/storage/ingest/pusher.go --------- Signed-off-by: Dimitar Dimitrov <[email protected]> Co-authored-by: gotjosh <[email protected]>
* kafka replay speed: rename CLI flags Make them a bit more consistent on what they mean and add better descriptions. Signed-off-by: Dimitar Dimitrov <[email protected]> * Clarify metrics Signed-off-by: Dimitar Dimitrov <[email protected]> * Rename flags Co-authored-by: gotjosh <[email protected]> * Update docs Signed-off-by: Dimitar Dimitrov <[email protected]> --------- Signed-off-by: Dimitar Dimitrov <[email protected]> Co-authored-by: gotjosh <[email protected]>
dimitarvdimitrov
force-pushed
the
dimitar/ingester/consume-latency-push-sharding
branch
from
c0d740c
to
fb30f39
Compare
* kafka replay speed: add support for metadata & source Signed-off-by: Dimitar Dimitrov <[email protected]> * Remove completed TODO Signed-off-by: Dimitar Dimitrov <[email protected]> * Use a single map Signed-off-by: Dimitar Dimitrov <[email protected]> * Make tests compile again Signed-off-by: Dimitar Dimitrov <[email protected]> --------- Signed-off-by: Dimitar Dimitrov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
N/A only here for illustrative purposes
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.