Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for lz4 algorithm to OTLP endpoint #9763

Merged
merged 12 commits into from
Nov 10, 2024
Merged

Add support for lz4 algorithm to OTLP endpoint #9763

merged 12 commits into from
Nov 10, 2024

Conversation

santileira
Copy link
Contributor

@santileira santileira commented Oct 28, 2024 •
edited by aknuds1
Loading

What this PR does

This PR adds support for lz4 algorithm to the distributor's OTLP endpoint.

Which issue(s) this PR fixes or relates to

Fixes #9259

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@CLAassistant
Copy link

CLAassistant commented Oct 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@santileira santileira marked this pull request as ready for review October 28, 2024 23:55
@santileira santileira requested a review from a team as a code owner October 28, 2024 23:55
@aknuds1 aknuds1 self-requested a review October 29, 2024 10:17
@santileira santileira mentioned this pull request Oct 29, 2024
Closed
@aknuds1
Copy link
Contributor

aknuds1 commented Oct 29, 2024

I will check w/ other OTel developers today, to gain a better understanding about the LZ4 support added to OTel Collector.

@santileira
Copy link
Contributor Author

I will check w/ other OTel developers today, to gain a better understanding about the LZ4 support added to OTel Collector.

Makes sense. Let me know the news please. Thanks

@aknuds1
Copy link
Contributor

aknuds1 commented Oct 29, 2024

@santileira out of curiosity, do you have any context on why one would use LZ4 over e.g. Snappy (Mimir supports Snappy for gRPC compression, as a data point)?

aknuds1
aknuds1 requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments.

CHANGELOG.md Outdated Show resolved Hide resolved
pkg/distributor/otel.go Outdated Show resolved Hide resolved
pkg/distributor/otel.go Outdated Show resolved Hide resolved
pkg/distributor/otel.go Outdated Show resolved Hide resolved
pkg/distributor/otel.go Outdated Show resolved Hide resolved
pkg/util/http.go Outdated Show resolved Hide resolved
pkg/util/http.go Outdated Show resolved Hide resolved
@santileira
Copy link
Contributor Author

@santileira out of curiosity, do you have any context on why one would use LZ4 over e.g. Snappy (Mimir supports Snappy for gRPC compression, as a data point)?

No TBH. I decided to do this based on the issue.

@santileira
Copy link
Contributor Author

@aknuds1 could you review the PR again?

@aknuds1
Copy link
Contributor

aknuds1 commented Nov 6, 2024

Yeah, I'm getting back to it this week I hope. Been a really busy few days.

aknuds1
aknuds1 approved these changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aknuds1 aknuds1 added enhancement New feature or request area/opentelemetry labels Nov 9, 2024
@aknuds1 aknuds1 changed the title Add support for lz4 algorithm on distributor Add support for lz4 algorithm to OTLP endpoint Nov 9, 2024
@aknuds1 aknuds1 enabled auto-merge (squash) November 9, 2024 10:18
aknuds1
aknuds1 requested changes Nov 9, 2024
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests fail due to an inconsistency. That also made me realize I don't want to drop the "Only" part of the error message, since it only makes it less precise.

pkg/distributor/otel.go Outdated Show resolved Hide resolved
pkg/distributor/otel_test.go Outdated Show resolved Hide resolved
auto-merge was automatically disabled November 10, 2024 16:40

Head branch was pushed to by a user without write access

aknuds1
aknuds1 approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@santileira
Copy link
Contributor Author

@stevesg could you review it? Thanks

@aknuds1 aknuds1 merged commit 55f47f8 into grafana:main Nov 10, 2024
29 checks passed
@santileira santileira deleted the santiago.leira/support-lz4-on-distributor branch November 10, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknuds1 aknuds1 aknuds1 approved these changes

@stevesg stevesg Awaiting requested review from stevesg stevesg is a code owner

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

Assignees
No one assigned
Labels
area/opentelemetry enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support LZ4 content encoding in the OTEL receiver once supported
3 participants
@santileira @CLAassistant @aknuds1