-
Notifications
You must be signed in to change notification settings - Fork 279
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Optimize duplicate queries occurring in AlertGroupFilter (#1809)
# What this PR does In `AlertGroupFilter` we currently have 11 duplicate queries which add ~1-2secs of unecessary request latency to `GET /api/internal/v1/alertgroups` calls. ![Screenshot 2023-04-20 at 17 57 49](https://user-images.githubusercontent.com/9406895/233589341-de5e53ca-f10b-4038-ad68-a857d1643bf2.png) The queries originate from the `queryset` callable arguments on several of the fields of the `AlertGroupFilter` class. These callables basically filter down their respective querysets to include only objects that belong to the currently authenticated user's organization. The duplicate queries are - 2 queries to fetch integrations - 2 queries to fetch escalation chains - 10 queries to fetch users At the moment, this PR is still a draft and doesn't work as intended. It's based off of [a suggestion from this discussion](carltongibson/django-filter#1572 (comment)) in the `django-filter` repo. See [this DjangoCon talk](https://youtu.be/e52S1SjuUeM?t=841) for more context. --------- Co-authored-by: Ildar Iskhakov <[email protected]>
- Loading branch information
1 parent
23c7a6f
commit 52ff041
Showing
2 changed files
with
37 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters