Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

ingress tls support #680

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

dsociative
Copy link

Added tls support to ingress template

@CLAassistant
Copy link

CLAassistant commented May 11, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for the contribution

@simonswine
Copy link
Collaborator

@dsociative in order to get a release of a new helm chart version, could you raise the version of the helm chart here:

@@ -38,4 +48,4 @@ spec:
path: /push.v1.PusherService/
Copy link
Collaborator

@cyriltovena cyriltovena May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR: We need to add the new pyroscope path I think.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsociative
Copy link
Author

@simonswine done

@simonswine simonswine enabled auto-merge (squash) May 12, 2023 11:41
auto-merge was automatically disabled May 12, 2023 13:02

Head branch was pushed to by a user without write access

@simonswine simonswine enabled auto-merge (squash) May 12, 2023 17:05
@Rustin170506
Copy link
Contributor

@dsociative The helm manifests need to update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants